Move module/discovery/import driver out-of-line into MLIRGenModule.cpp (review doc 1)#219
Merged
Merged
Conversation
…p (review doc 1) Third slice of the TU split: the module driver family (report, loadMainSourceFile/loadSourceFile/loadSourceBuf, mlirGenSourceFile, mlirDiscoverAllDependencies, mlirCodeGenModule, namespace registration, include loading, shared-lib import; 24 methods, ~930 lines) moves from inline bodies in MLIRGenImpl.h to MLIRGenModule.cpp. Method-level #ifdef guards (GENERATE_IMPORT_INFO_USING_D_TS_FILE) are kept around both the declarations and the moved definitions. Verified: MLIRGenTests 12/12, full ctest 681/681 (JIT + AOT). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third mechanical slice of the §1 TU split from docs/MLIRGen-refactoring-review.md (follows #217, #218).
What
MLIRGenModule.cpp(new): the contiguous module-driver family —report, source loading (loadMainSourceFile/loadSourceFile/loadSourceBuf),mlirGenSourceFile, codegen init, dependency-declaration emission,mlirDiscoverAllDependencies,mlirCodeGenModule, namespace registration/entry,mlirGenInclude, and shared-lib import (24 methods, ~930 lines) — defined out-of-line.MLIRGenImpl.hshrinks from 22,096 to 21,225 lines.#ifdef GENERATE_IMPORT_INFO_USING_D_TS_FILEguards are preserved around both the declarations in the header and the definitions in the new TU, so conditional compilation is unchanged.Same mechanical recipe as #217/#218: bodies byte-identical,
MLIRGenImpl::qualification added, default arguments stay on declarations only.Verification
MLIRGenTests12/12.🤖 Generated with Claude Code